promiseFunctionAsyncRule.js 3.5 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970
  1. "use strict";
  2. /**
  3. * @license
  4. * Copyright 2016 Palantir Technologies, Inc.
  5. *
  6. * Licensed under the Apache License, Version 2.0 (the "License");
  7. * you may not use this file except in compliance with the License.
  8. * You may obtain a copy of the License at
  9. *
  10. * http://www.apache.org/licenses/LICENSE-2.0
  11. *
  12. * Unless required by applicable law or agreed to in writing, software
  13. * distributed under the License is distributed on an "AS IS" BASIS,
  14. * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  15. * See the License for the specific language governing permissions and
  16. * limitations under the License.
  17. */
  18. Object.defineProperty(exports, "__esModule", { value: true });
  19. var tslib_1 = require("tslib");
  20. var tsutils_1 = require("tsutils");
  21. var ts = require("typescript");
  22. var Lint = require("../index");
  23. var Rule = /** @class */ (function (_super) {
  24. tslib_1.__extends(Rule, _super);
  25. function Rule() {
  26. return _super !== null && _super.apply(this, arguments) || this;
  27. }
  28. Rule.prototype.applyWithProgram = function (sourceFile, program) {
  29. return this.applyWithFunction(sourceFile, walk, undefined, program.getTypeChecker());
  30. };
  31. /* tslint:disable:object-literal-sort-keys */
  32. Rule.metadata = {
  33. ruleName: "promise-function-async",
  34. description: "Requires any function or method that returns a promise to be marked async.",
  35. rationale: Lint.Utils.dedent(templateObject_1 || (templateObject_1 = tslib_1.__makeTemplateObject(["\n Ensures that each function is only capable of 1) returning a rejected promise, or 2)\n throwing an Error object. In contrast, non-`async` `Promise`-returning functions\n are technically capable of either. This practice removes a requirement for consuming\n code to handle both cases.\n "], ["\n Ensures that each function is only capable of 1) returning a rejected promise, or 2)\n throwing an Error object. In contrast, non-\\`async\\` \\`Promise\\`-returning functions\n are technically capable of either. This practice removes a requirement for consuming\n code to handle both cases.\n "]))),
  36. optionsDescription: "Not configurable.",
  37. options: null,
  38. optionExamples: [true],
  39. type: "typescript",
  40. typescriptOnly: false,
  41. requiresTypeInfo: true,
  42. };
  43. /* tslint:enable:object-literal-sort-keys */
  44. Rule.FAILURE_STRING = "functions that return promises must be async";
  45. return Rule;
  46. }(Lint.Rules.TypedRule));
  47. exports.Rule = Rule;
  48. function walk(ctx, tc) {
  49. return ts.forEachChild(ctx.sourceFile, function cb(node) {
  50. switch (node.kind) {
  51. case ts.SyntaxKind.MethodDeclaration:
  52. case ts.SyntaxKind.FunctionDeclaration:
  53. if (node.body === undefined) {
  54. break;
  55. }
  56. // falls through
  57. case ts.SyntaxKind.FunctionExpression:
  58. case ts.SyntaxKind.ArrowFunction:
  59. if (!tsutils_1.hasModifier(node.modifiers, ts.SyntaxKind.AsyncKeyword) && returnsPromise(node, tc)) {
  60. ctx.addFailure(node.getStart(ctx.sourceFile), node.body.pos, Rule.FAILURE_STRING);
  61. }
  62. }
  63. return ts.forEachChild(node, cb);
  64. });
  65. }
  66. function returnsPromise(node, tc) {
  67. var type = tc.getReturnTypeOfSignature(tc.getTypeAtLocation(node).getCallSignatures()[0]);
  68. return type.symbol !== undefined && type.symbol.name === "Promise";
  69. }
  70. var templateObject_1;